Feature/userinfo - #273
Open
JasonRobertFrancis wants to merge 21 commits into
Open
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 50.07% 56.18% +6.11%
==========================================
Files 998 1193 +195
Lines 58354 80337 +21983
Branches 5853 6165 +312
==========================================
+ Hits 29221 45139 +15918
- Misses 28228 34227 +5999
- Partials 905 971 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| { | ||
| var result = System.Text.Json.JsonSerializer.Deserialize<DateTime?>($"\"{input}\"", options); | ||
| Assert.NotNull(result); | ||
| var nonNullResult = result.Value; |
| new("scope", "api_access") | ||
| }; | ||
|
|
||
| var formContent = new FormUrlEncodedContent(formParams); |
Comment on lines
+401
to
+407
| foreach (var name in nameList) | ||
| { | ||
| if (!string.IsNullOrEmpty(name.StudentName) && name.ActivityDate.HasValue) | ||
| { | ||
| names.Add($"{name.StudentName} ({name.ActivityDate:MM/dd/yyyy})"); | ||
| } | ||
| } |
Comment on lines
+1721
to
+1731
| foreach (var middlePart in middleParts) | ||
| { | ||
| if (middlePart.Length > 0) | ||
| { | ||
| var variation = $"{name} {middlePart[0]}"; | ||
| if (!nameVariations.Contains(variation)) | ||
| { | ||
| nameVariations.Add(variation); | ||
| } | ||
| } | ||
| } |
Comment on lines
+1325
to
+1340
| foreach (var history in historyData) | ||
| { | ||
| var ucpathResult = new UCPathResult | ||
| { | ||
| JobCode = history.Jobcode, | ||
| JobCodeDescription = history.JobcodeDesc, | ||
| DepartmentId = history.Deptid, | ||
| DepartmentDescription = history.DeptDesc, | ||
| ActionDescription = history.ActionDescr, | ||
| PositionEffectiveDate = history.PositionEffdt.HasValue ? DateOnly.FromDateTime(history.PositionEffdt.Value) : null, | ||
| ReportsTo = GetReportsToName(history), | ||
| ReportsToPosition = GetReportsToPosition(history) | ||
| }; | ||
|
|
||
| result.UCPathHistory.Add(ucpathResult); | ||
| } |
Comment on lines
+1643
to
+1650
| foreach (var groupDn in allGroups) | ||
| { | ||
| var formattedGroup = AdFormat(groupDn, domains); | ||
| if (!string.IsNullOrEmpty(formattedGroup)) | ||
| { | ||
| result.ADMemberOf.Add(formattedGroup); | ||
| } | ||
| } |
Comment on lines
+683
to
+712
| foreach (var perm in permissions) | ||
| { | ||
| var parts = perm.Split('.'); | ||
| var partsToProcess = parts.Skip(1).ToList(); | ||
| if (!partsToProcess.Any()) | ||
| { | ||
| continue; | ||
| } | ||
|
|
||
| var currentList = roots; | ||
| for (int i = 0; i < partsToProcess.Count; i++) | ||
| { | ||
| var part = partsToProcess[i]; | ||
| var node = currentList.FirstOrDefault(n => n.Name == part); | ||
| if (node == null) | ||
| { | ||
| node = new PermissionNode | ||
| { | ||
| Name = part, | ||
| FullPath = string.Join('.', parts.Take(i + 2)) | ||
| }; | ||
| currentList.Add(node); | ||
| } | ||
| if (i == partsToProcess.Count - 1) | ||
| { | ||
| node.IsPermission = true; | ||
| } | ||
| currentList = node.Children; | ||
| } | ||
| } |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
|
@JasonRobertFrancis You should rebase this off the latest main branch since this doesn't have the GitHub Actions for code quality checks running |
…modal) and responds to code-quality bot userinfo recommendations
JasonRobertFrancis
force-pushed
the
feature/userinfo
branch
from
July 30, 2026 20:03
22567dc to
694ecd4
Compare
Comment on lines
+1113
to
+1121
| foreach (var role in filteredRoles) | ||
| { | ||
| string displayName = role.DisplayName ?? role.Role; | ||
| result.SystemRoles.Add(new SystemRole | ||
| { | ||
| System = system, | ||
| DisplayName = FormatPermissionName(displayName) | ||
| }); | ||
| } |
Comment on lines
+173
to
+176
| catch | ||
| { | ||
| return new List<string>(); | ||
| } |
Comment on lines
+231
to
+234
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine($"Warning: PopulateDirectoryInfoAsync LDAP failed: {ex.Message}"); | ||
| } |
Contributor
|
@JasonRobertFrancis #261 just merged to main and conflicts with this branch. Small scope: one file, Both branches reworked the same methods, so every region is "main moved it" vs "your feature changed it in place":
The two sides are complementary rather than contradictory: keep main's structure, fold in your Optional: prompt for a coding agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.